-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next/659/70x/20241205/v1 #12231
Merged
victorjulien
merged 5 commits into
OISF:main-7.0.x
from
victorjulien:next/659/70x/20241205/v1
Dec 6, 2024
Merged
next/659/70x/20241205/v1 #12231
victorjulien
merged 5 commits into
OISF:main-7.0.x
from
victorjulien:next/659/70x/20241205/v1
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just updates some internal dependencies to our own crates in the work-space.
Includes Cargo.lock.in generated for just this single crate update (minimal atomic update to keep Cargo.lock in sync with Cargo.toml). This prevents the clippy warning: 508 | #[derive(FromPrimitive, Debug)] | ^------------ | | | `FromPrimitive` is not local | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_IsakmpPayloadType` 509 | pub enum IsakmpPayloadType { | ----------------- `IsakmpPayloadType` is not local | = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) Backport of 8e408d3.
But we should fix all these soon. (cherry picked from commit 4c12165)
'///' style rust comments/documentation come before the item being documented. Spotted by clippy. (cherry picked from commit aa6e94f)
Fix provided by cargo clipy --fix. Backport of 7bdbe7e.
catenacyber
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistent with single approved PR
jasonish
approved these changes
Dec 5, 2024
Information: QA ran without warnings. Pipeline 23700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging: